Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tekton integration tests #28

Closed
ckadner opened this issue Mar 17, 2020 · 11 comments · Fixed by #174
Closed

Add Tekton integration tests #28

ckadner opened this issue Mar 17, 2020 · 11 comments · Fixed by #174
Assignees
Labels

Comments

@ckadner
Copy link
Member

ckadner commented Mar 17, 2020

For a start the integration tests would assume (and test for) a working Tekton cluster. The user/developer would make sure that the kubectl and tkn environment is configured and the Python script would rely on shell commands to apply the Tekton YAML files, start Tekton pipelines, check pipeline run output and remove the resources created in the course of the integration tests.

In the future this setup should be improved to use containers for Tekton and appropriate Python libraries to execute the tests.

Conceptually, each individual integration test would take one of the Golden YAML files from the sdk/python/tests/compiler/testdata folder and do:

  • kubectl apply -f some.yaml
  • tkn pipeline start some-pipeline
  • tkn pipeline logs parallel-pipeline --last > some-pipeline-run.log
  • some smart diff of some-pipeline-run.log and some-pipeline-run.expected.log which was previously captured
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.99

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@ckadner
Copy link
Member Author

ckadner commented Mar 17, 2020

/good-first-issue

@k8s-ci-robot k8s-ci-robot added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 17, 2020
@kalakandi
Copy link

I'm on it

@animeshsingh
Copy link
Collaborator

/assign @kalakandi

@ckadner
Copy link
Member Author

ckadner commented Mar 25, 2020

Hi @kalakandi, are you still working in the integration tests?

@kalakandi
Copy link

Hi @ckadner, yes was reading the kubernetes docs as I m a little new to it, i need a little guidance TBH

@ckadner
Copy link
Member Author

ckadner commented Mar 27, 2020

/area testing

@ckadner
Copy link
Member Author

ckadner commented Mar 27, 2020

/remove-good-first-issue

@k8s-ci-robot k8s-ci-robot removed the good first issue Good for newcomers label Mar 27, 2020
@ckadner
Copy link
Member Author

ckadner commented Mar 27, 2020

... was reading the kubernetes docs as I m a little new to it, i need a little guidance TBH

@kalakandi -- I may have mislabeled this issue. It is not a good first issue for people who are unfamiliar with Kubernetes. I intended to mark this as a good issue for people who are new to this project, but it requires solid knowledge/experience with Kubernetes, Kubeflow, Tekton and Python. There may be better issues to start with than this one.

@kalakandi
Copy link

Ok, then I'll work on another issue. Please unassign

@kalakandi kalakandi removed their assignment Mar 28, 2020
@ckadner
Copy link
Member Author

ckadner commented Mar 30, 2020

/assign

ckadner added a commit to ckadner/kfp-tekton that referenced this issue Jun 11, 2020
- Regenerate all "Golden" YAML files with PipelineRun
- Dynamically generate E2E test cases from "Golden" YAML files
- Add e2e_test target to Makefile
- Generate new "Golden" log files from Tekton pipeline run
- Fix PendingDeprecationWarning: dsl.ContainerOp....` will be removed in future releases
  Use `dsl.ContainerOp.container....` instead.
- Fix UserWarning: Missing type name was inferred as ...

Resolves kubeflow#28
k8s-ci-robot pushed a commit that referenced this issue Jun 11, 2020
- Regenerate all "Golden" YAML files with PipelineRun
- Dynamically generate E2E test cases from "Golden" YAML files
- Add e2e_test target to Makefile
- Generate new "Golden" log files from Tekton pipeline run
- Fix PendingDeprecationWarning: dsl.ContainerOp....` will be removed in future releases
  Use `dsl.ContainerOp.container....` instead.
- Fix UserWarning: Missing type name was inferred as ...

Resolves #28
gmfrasca pushed a commit to gmfrasca/data-science-pipelines-tekton that referenced this issue Sep 7, 2022
Fix Visualization Server dependencies for Python 3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants