Support input artifact #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
/unhold |
|
This will be the last PR before we do the major refactor for #96 |
ckadner
approved these changes
Apr 22, 2020
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
HumairAK
referenced
this pull request
in red-hat-data-services/data-science-pipelines-tekton
May 16, 2023
Update DSPA routes' Insecureterminationpolicy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Resolves #64
Description of your changes:
This is a follow up PR for #92 to support input artifacts. In KFP, the input artifacts are passed from the parameter outputs and loaded as a file instead of loading it from S3. The implementation details are located at
https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/compiler/_op_to_template.py#L123-L145
https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/compiler/_op_to_template.py#L223-L225
From the source code, you can see there's no S3 involved with passing inputs as artifacts in all cases. The only limitation we have right now is missing #63 for big file compression which none of the example or test is using it.
Put it on hold for now until we merged #92 for the artifact support.
/hold
Environment tested:
python --version): 3.6.4tkn version): 0.11kubectl version): 1.16/etc/os-release):