Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 metrics visualization #5668

Closed
5 tasks done
Bobgy opened this issue May 18, 2021 · 11 comments · Fixed by kubeflow/website#2786
Closed
5 tasks done

v2 metrics visualization #5668

Bobgy opened this issue May 18, 2021 · 11 comments · Fixed by kubeflow/website#2786
Assignees
@zijianjoy
Labels
size/L

Comments

@Bobgy
Copy link
Contributor

Bobgy commented May 18, 2021 •
edited
Loading

components can output metrics artifacts that are rendered in UI.
Sample pipeline: https://github.com/kubeflow/pipelines/blob/89364315e96ca0e14106ef178336f72265a8e91a/samples/test/metrics_visualization_v2.py

TODOs:

Also suggest trying to write new UI code in recent best practices and try to separate them from existing components. We want to take a gradual approach to modernize the UI codebase.
@Bobgy
Copy link
Contributor Author

Bobgy commented May 18, 2021

b/186482243

@Bobgy
Copy link
Contributor Author

Bobgy commented May 18, 2021

/assign @zijianjoy

@Bobgy Bobgy changed the title [v2compat] v2 metrics visualization v2 metrics visualization May 18, 2021
@Bobgy Bobgy changed the title v2 metrics visualization [UI] v2 metrics visualization May 18, 2021
@Bobgy Bobgy changed the title [UI] v2 metrics visualization v2 metrics visualization support May 18, 2021
@Bobgy Bobgy changed the title v2 metrics visualization support v2 metrics visualization May 18, 2021
@Bobgy Bobgy mentioned this issue May 21, 2021
Closed
11 tasks
@zijianjoy
Copy link
Collaborator

Do we visualize HTML, Markdown, Tensorboard in the new visualization tab?

@Bobgy
Copy link
Contributor Author

Bobgy commented May 21, 2021

Do we visualize HTML, Markdown, Tensorboard in the new visualization tab?

Yes, they are tracked in a different issue in P1.

@Bobgy Bobgy added the size/L label May 24, 2021
@zijianjoy zijianjoy mentioned this issue May 24, 2021
Merged
1 task
@zijianjoy
Copy link
Collaborator

We might need to update documentation https://www.kubeflow.org/docs/components/pipelines/sdk/output-viewer/

@Bobgy
Copy link
Contributor Author

Bobgy commented May 29, 2021

We might need to update documentation https://www.kubeflow.org/docs/components/pipelines/sdk/output-viewer/

That's a good point! Note, the update work item is already tracked in #5666 (comment).

google-oss-robot pushed a commit that referenced this issue Jun 1, 2021
@zijianjoy
feat(frontend): MetricsTab for NodeDetail, ROC Curve from MLMD custom…
601b104 
… property. Issue #5668 (#5731)

* feat(frontend): MetricsTab for NodeDetail, ROC Curve from MLMD custom property

* add back test renderer

* remove debug tool

* address nit comments

* more comment address

* merge metrics to visualization

* error boundary, revert banner change, more testing, data validation

* attempt to use actual function

* clear queryclient

* address comments

* address comments

* address comments
@zijianjoy
Copy link
Collaborator

Definition of System.ClassificationMetrics: https://github.com/kubeflow/pipelines/blob/master/sdk/python/kfp/dsl/io_types.py#L122

@zijianjoy zijianjoy mentioned this issue Jun 2, 2021
Merged
1 task
@zijianjoy
Copy link
Collaborator

Hello Yuan @Bobgy , what is the goal of this item?

add MLMD state verification of this pipeline

Does it mean we check the status of execution? Or the status of complete pipeline run? What do we want to visualize when state is success?

@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 3, 2021

@zijianjoy I just figured out moving custom properties to metadata field in a separate PR, so I think I can take add MLMD state verification of this pipeline task too in the same PR.

google-oss-robot pushed a commit that referenced this issue Jun 3, 2021
@zijianjoy
feat(frontend): Support v2 confusion matrix visualization. Issue #5668 (
ef33b9e 
#5781)

* feat(frontend): Shows ConfusionMatrix in Metrics Tab

* adjust uI

* remove comment

* definition description

* moving wrapper

* runtype check
This was referenced Jun 4, 2021
Closed
Merged
google-oss-robot pushed a commit that referenced this issue Jun 9, 2021
@zijianjoy @Bobgy
feat(frontend): Support Scalar metrics in V2 compatible mode. Partial #…
22bc9e2 
…5668 (#5811)

* feat(frontend) Support Scalar metrics in V2 compatible mode

* remove unused

* Update frontend/src/components/viewers/MetricsVisualizations.tsx

Co-authored-by: Yuan (Bob) Gong <[email protected]>

* Update frontend/src/components/viewers/MetricsVisualizations.tsx

Co-authored-by: Yuan (Bob) Gong <[email protected]>

* Update frontend/src/components/viewers/MetricsVisualizations.tsx

Co-authored-by: Yuan (Bob) Gong <[email protected]>

* Update frontend/src/components/viewers/MetricsVisualizations.tsx

Co-authored-by: Yuan (Bob) Gong <[email protected]>

* fix adjustmnet

* address comment

Co-authored-by: Yuan (Bob) Gong <[email protected]>
@zijianjoy zijianjoy mentioned this issue Jun 21, 2021
Merged
@Bobgy
Copy link
Contributor Author

Bobgy commented Jun 28, 2021

All is done

@Bobgy Bobgy closed this as completed Jun 28, 2021
@kimkihoon0515
Copy link

@Bobgy Hi, I'm trying to use test code for visualizing confusion matrix metrics but it seems doesn't work well can you help me please??
#8675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zijianjoy zijianjoy

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pipelines) KFP V2 visualization doc zijianjoy/website
3 participants
@Bobgy @zijianjoy @kimkihoon0515