Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate Frontend tests to a GHA Workflow #10972

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

DharmitD
Copy link
Contributor

@DharmitD DharmitD commented Jul 1, 2024

Description of your changes:
Resolves #10879

Converts the Prow frontend test to a GH Action Workflow.

Here's a working GH Action run on my fork: https://github.com/DharmitD/data-science-pipelines-argo/actions/runs/9525123655/job/26258863870

PR to remove the frontend test from prow config: GoogleCloudPlatform/oss-test-infra#2302

PR to remove frontend files not required anymore: #10973

Checklist:

Copy link
Contributor Author

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

@DharmitD: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hbelmiro
Copy link
Contributor

hbelmiro commented Jul 1, 2024

@jlyaoyuli @zijianjoy we still need approval from one of you guys.

cc @DharmitD

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DharmitD
Copy link
Contributor Author

DharmitD commented Jul 1, 2024

@jlyaoyuli @zijianjoy we still need approval from one of you guys.

cc @DharmitD

@hbelmiro I added the removal of frontend files to a separate PR: #1097
cc: @jlyaoyuli @zijianjoy

@rimolive
Copy link
Member

rimolive commented Jul 1, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 1, 2024
@google-oss-prow google-oss-prow bot merged commit 2fb4922 into kubeflow:master Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Prow front end tests to GH Actions
3 participants