-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(components): Delete deprecated dataproc components #5045
chore(components): Delete deprecated dataproc components #5045
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ark-kun, chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Need to clean up these as well:
|
New changes are detected. LGTM label has been removed. |
Got catch! following this I found a couple more references that need to be deleted. |
/lgtm |
/hold cancel |
These deprecated components don't build in post-submit cloud build as their Dockerfile is based on Python 2.7
https://pantheon.corp.google.com/cloud-build/builds/2ff01688-9b36-4699-866a-86cbcd46ba14;step=20?project=ml-pipeline-test
Confirmed with @Ark-kun that it's fine to delete the code.
Partially fixes: #5007