Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Minor fix to add CoreV1 to scheme #184

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Jun 27, 2019

@coveralls
Copy link

coveralls commented Jun 27, 2019

Coverage Status

Coverage remained the same at 85.217% when pulling 9646d76 on johnugeorge:corev1 into 614cdee on kubeflow:master.

@johnugeorge
Copy link
Member Author

johnugeorge commented Jun 28, 2019

/hold
till 0.6 release

@johnugeorge
Copy link
Member Author

/hold release

@johnugeorge
Copy link
Member Author

/hold cancel

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@gaocegege
Copy link
Member

/retest

1 similar comment
@gaocegege
Copy link
Member

/retest

@richardsliu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 3a8a1e4 into kubeflow:master Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants