This repository has been archived by the owner on Sep 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchihe
force-pushed
the
generate_sdk
branch
from
December 10, 2019 02:31
dbab978
to
df796a2
Compare
Failed to set kubeflow in CI test.
Seems this caused by kubeflow/kubeflow#4484, the ksonnet registry has been removed, we need to enhance this. |
jinchihe
force-pushed
the
generate_sdk
branch
9 times, most recently
from
December 10, 2019 10:00
299c7ca
to
94e2a96
Compare
jinchihe
changed the title
WIP: Generate Kubeflow PyTorchJob SDK
Generate Kubeflow PyTorchJob SDK
Dec 10, 2019
/assign @johnugeorge @gaocegege The PR is ready for reviewing now, please see the PR description section for details. Thanks a lot! |
jinchihe
force-pushed
the
generate_sdk
branch
from
December 10, 2019 10:07
94e2a96
to
1a30426
Compare
Looks great. Thanks @jinchihe for this contribution |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leileiwan
added a commit
to leileiwan/pytorch-operator
that referenced
this pull request
Dec 11, 2019
Generate Kubeflow PyTorchJob SDK (kubeflow#227)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in kubeflow/training-operator#167, and requried by @johnugeorge.
The PR is includes:
kubeflow-pytorchjob
andfrom kubeflow import pytorchjob
.kubeflow-pytorch
SDK to Pypi: https://pypi.org/project/kubeflow-pytorchjob/Next: