Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

replace gopkg.in/yaml.v2 with github.com/kubernetes-sigs/yaml repo #238

Merged
merged 2 commits into from
Dec 16, 2019

Conversation

xrmzju
Copy link
Contributor

@xrmzju xrmzju commented Dec 16, 2019

fixed issues-236

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link

Hi @xrmzju. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xrmzju
Copy link
Contributor Author

xrmzju commented Dec 16, 2019

/assign @gaocegege

@johnugeorge
Copy link
Member

/ok-to-test

@johnugeorge
Copy link
Member

can you sign CLA too?

@coveralls
Copy link

coveralls commented Dec 16, 2019

Coverage Status

Coverage remained the same at 22.97% when pulling e2b16e6 on xrmzju:master into edfcb53 on kubeflow:master.

@xrmzju
Copy link
Contributor Author

xrmzju commented Dec 16, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 80821be into kubeflow:master Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add cpu/mem resource limit to worker init container causes unmarshal error
6 participants