Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

SDK supports getting PyTorchJob training process or logs #252

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

jinchihe
Copy link
Member

@jinchihe jinchihe commented Jan 14, 2020

kubeflow-pytorchjob SDK supports getting training process or logs and pod name of the PyTorchJob.

Related with kubeflow/training-operator#1129

@coveralls
Copy link

coveralls commented Jan 14, 2020

Coverage Status

Coverage remained the same at 22.97% when pulling 53bf0cd on jinchihe:add_api_getting_log into 9d16b59 on kubeflow:master.

@jinchihe jinchihe force-pushed the add_api_getting_log branch from 1cd22ef to 53bf0cd Compare January 14, 2020 09:35
@jinchihe jinchihe changed the title WIP: SDK supports get PyTorchJob training process or logs SDK supports getting PyTorchJob training process or logs Jan 15, 2020
@jinchihe
Copy link
Member Author

/cc @gaocegege @johnugeorge

The PR is ready for reviewing. Great thanks!

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@johnugeorge johnugeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7cff3fe into kubeflow:master Jan 15, 2020
@jinchihe jinchihe deleted the add_api_getting_log branch January 16, 2020 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants