Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crds to add defaults for k8s 1.18+ #1084

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

jkleckner
Copy link
Contributor

PR #1045 [1] appears to have accidentally reverted #986 [2] which added
defaults to the protocol field to work with versions of k8s 1.18+

This PR also draws on kudobuilder/operators#297 [3]

[1] #1045

[2] #986

[3] kudobuilder/operators#297

PR kubeflow#1045 [1] appears to have accidentally reverted kubeflow#986 [2] which added
defaults to the protocol field to work with versions of k8s 1.18+

This PR also draws on kudobuilder/operators#297 [3]


[1] kubeflow#1045

[2] kubeflow#986

[3] kudobuilder/operators#297
@liyinan926 liyinan926 merged commit 863bf2b into kubeflow:master Nov 25, 2020
@jkleckner jkleckner deleted the fix-crds-k8s-1.18 branch November 25, 2020 18:02
@ordukhanian
Copy link
Contributor

Hello,
Could you please release a new version of GCP Operator with this fix?
We are using the previous helm chart which is now deprecated, and would like to upgrade.

@jkleckner
Copy link
Contributor Author

In the meantime, you can clone the repo and install using something like (adjust namespaces to your liking).
Because of functional changes,
I actually think that the 0.8.6 chart version might also make sense to bundle in the repo.

helm \
  install \
  spark-operator \
  /path-to-your-clone/github.com/GoogleCloudPlatform/spark-on-k8s-operator/charts/spark-operator-chart \
  --namespace spark-operator \
  --set        sparkJobNamespace=spark \
  --set        enableWebhook=true \
  --set        webhook.enable=true \
  --set        webhookPort=443 \
  --set-string enableMetrics=true

jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
PR kubeflow#1045 [1] appears to have accidentally reverted kubeflow#986 [2] which added
defaults to the protocol field to work with versions of k8s 1.18+

This PR also draws on kudobuilder/operators#297 [3]


[1] kubeflow#1045

[2] kubeflow#986

[3] kudobuilder/operators#297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants