Add prometheus containr port name #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyinan926
reviewed
Dec 3, 2020
pkg/webhook/patch.go
Outdated
| @@ -401,6 +401,7 @@ func addContainerPort(pod *corev1.Pod, port int32, protocol string) *patchOperat | |||
|
|
|||
| path := fmt.Sprintf("/spec/containers/%d/ports", i) | |||
| containerPort := corev1.ContainerPort{ | |||
| Name: "metrics", | |||
There was a problem hiding this comment.
The function addContainerPort is a generic one and not specific to the Prometheus port. What you probably should do is pass in the port name and specify the port name in the caller.
There was a problem hiding this comment.
@liyinan926
Hello,
There is a suggestion for this. #1101
I would appreciate it if you could review it.
Thanks!
There was a problem hiding this comment.
@liyinan926 Added port name from caller
liyinan926
reviewed
Dec 12, 2020
| @@ -3600,6 +3600,8 @@ spec: | |||
| maximum: 49151 | |||
| minimum: 1024 | |||
| type: integer | |||
| portName: | |||
There was a problem hiding this comment.
This is also needed in the ScheduledSparkApplication CRD.
There was a problem hiding this comment.
@liyinan926 Thanks, I updated it
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
* Add prometheus containr port name * jmx exporter port name can be added by caller * Add portName CRD to scheduled spark application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PodMonitoris one of prometheus operator CRDs, and it collects metrics from pod selector.For collecting, it requires port name of metrics
https://github.com/prometheus-operator/prometheus-operator/blob/master/Documentation/api.md#podmetricsendpoint
then, I have added metrics port name when mutating pod
it's example of
PodMonitor