Support Prometheus PodMonitor Deployment (#1106) #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyinan926
reviewed
Dec 12, 2020
| | metrics.prefix | string | `""` | Metric prefix, will be added to all exported metrics | | ||
| | nameOverride | string | `""` | String to partially override `spark-operator.fullname` template (will maintain the release name) | | ||
| | nodeSelector | object | `{}` | Node labels for pod assignment | | ||
| | podAnnotations | object | `{}` | Additional annotations to add to the pod | | ||
| | podMonitor.create | bool| `false` | Create a prometheus pod monitor for operator's pod. Note that prometheus metrics should be enabled as well.| |
There was a problem hiding this comment.
Should we use enable instead of create?
* Supported Prometheus monitoring via pod monitor for the Spark operator's pod. * Added Prometheus `metrics.portName` to use it for `podMonitor.podMetricsEndpoint` configuration, becuse `targetPort` has been deprecated by Prometheus.
ordukhanian
force-pushed
the
support_podmonitor_for_operator
branch
from
286ed26 to
1d57a95
Compare
|
Looks like you forgot to upgrade the Chart version number. |
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
* Supported Prometheus monitoring via pod monitor for the Spark operator's pod. * Added Prometheus `metrics.portName` to use it for `podMonitor.podMetricsEndpoint` configuration, becuse `targetPort` has been deprecated by Prometheus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metrics.portNameto use it forpodMonitor.podMetricsEndpointconfiguration, becusetargetPorthas been deprecated by Prometheus.