Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct hook annotation for webhook job #1193

Merged
merged 1 commit into from
Mar 7, 2021
Merged

correct hook annotation for webhook job #1193

merged 1 commit into from
Mar 7, 2021

Conversation

chaudhryfaisal
Copy link
Contributor

correct name forhook is pre-upgrade and not pre-update https://helm.sh/docs/topics/charts_hooks/

correct name for pre hook is `pre-upgrade` and not `pre-update` https://helm.sh/docs/topics/charts_hooks/
Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@liyinan926 liyinan926 merged commit 9a6e667 into kubeflow:master Mar 7, 2021
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
correct name for pre hook is `pre-upgrade` and not `pre-update` https://helm.sh/docs/topics/charts_hooks/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants