[#1239] Custom service port name for spark application UI #1240
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
marcozov
force-pushed
the
feature/custom-service-port-name-PR
branch
from
4062b6f to
a70d13a
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
marcozov
force-pushed
the
feature/custom-service-port-name-PR
branch
from
a70d13a to
c139658
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
marcozov
force-pushed
the
feature/custom-service-port-name-PR
branch
from
c139658 to
81c1cb6
Compare
marcozov
force-pushed
the
feature/custom-service-port-name-PR
branch
from
81c1cb6 to
36ffa8f
Compare
| @@ -204,3 +211,15 @@ func getUIServicePort(app *v1beta2.SparkApplication) (int32, error) { | |||
| } | |||
| return defaultSparkWebUIPort, nil | |||
| } | |||
|
|
|||
| func getUIServicePortName(app *v1beta2.SparkApplication) (string, error) { | |||
|
|
|||
There was a problem hiding this comment.
This empty line can be removed.
| @@ -204,3 +211,15 @@ func getUIServicePort(app *v1beta2.SparkApplication) (int32, error) { | |||
| } | |||
| return defaultSparkWebUIPort, nil | |||
| } | |||
|
|
|||
| func getUIServicePortName(app *v1beta2.SparkApplication) (string, error) { | |||
There was a problem hiding this comment.
Looks like this method does not need the second return value of type error.
…beflow#1240) * [operator] Adding service port name for spark UI exposure * cleanup
A proposal for solving #1239 .
This PR makes it possible to specify the service port name for exposing the spark UI.