add failure context to recordExecutorEvent #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liyinan926 can review this PR or tell us who else we should ask for a review? |
liyinan926
reviewed
Jun 28, 2021
| switch state { | ||
| case v1beta2.ExecutorCompletedState: | ||
| c.recorder.Eventf(app, apiv1.EventTypeNormal, "SparkExecutorCompleted", "Executor %s completed", name) |
There was a problem hiding this comment.
How does the output look like for args?
There was a problem hiding this comment.
Same as before we use c.recorder.Eventf which already accept variadics parameters
per doc:
Eventf(object runtime.Object, eventtype, reason, messageFmt string, args ...interface{})
We already use something similar in recordSparkApplicationEvent for v1beta2.FailedState
liyinan926
approved these changes
Jun 30, 2021
ImpSy
added a commit
to datamechanics/spark-on-k8s-operator
that referenced
this pull request
Aug 18, 2021
liyinan926
pushed a commit
that referenced
this pull request
Aug 20, 2021
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since they were no traction on this issue: #1263
I've decided to implement solution 1 for executors
If i need to change anything do not hesitate