Updating API version of admissionregistration.k8s.io #1401
Conversation
|
As this version of operator contains breaking changes, should we also modify the operator version and make other changes to docs? |
|
Thanks for the PR! I think we should also modify the operator version and make relevant doc changes. I can cut a new release afterwards. |
|
Thanks @liyinan926, |
|
Hi @liyinan926, |
README.md
Outdated
| @@ -22,6 +22,8 @@ Customization of Spark pods, e.g., mounting arbitrary volumes and setting pod af | |||
|
|
|||
| * Version >= 1.13 of Kubernetes to use the [`subresource` support for CustomResourceDefinitions](https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#subresources), which became beta in 1.13 and is enabled by default in 1.13 and higher. | |||
|
|
|||
| * Version >= 1.16 of Kubernetes to use the MutatingWebhook and ValidatingWebhook of admissionregistration.k8s.io/v1 | |||
There was a problem hiding this comment.
Nit: please add a period at the end, and use "`" around the k8s resources.
There was a problem hiding this comment.
Wrapped k8s resources in code block and also added apiVersion: before admissionregistration.k8s.io/v1.
|
@liyinan926 @sairamankumar2 : It would be great, if you can update the OperatorHub with the latest version. I have been asked to update the operator from version 2.4 to the version that will be supported by openshift 4.9 |
* Added webhook timeout variable * made timeout variable to be private * Fixed chart version * Bumped admission & admissionregistration ver to v1 * Bumped operator version to v1beta2-1.3.0-3.1.1 * Fixed typo in README.md * Fixed typos in README.md Co-authored-by: Sairaman Kumar <[email protected]>
This PR upgrades API version of admission registration objects of kind MutatingWebhook and ValidatingWebhook to v1 from v1beta1. v1beta1 version of admission registration is not supported in 1.22+ version of Kubernetes cluster.
The PR closes #1265 and #1375
With some additional work can fix #1339