fix: add pre-upgrade hook to rbac resources #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @yuchaoran2011 could you approve me running the workflows? |
|
Could you please rebase this PR? |
Signed-off-by: York Chen <[email protected]>
cwyl02
force-pushed
the
cwyl02/add-rbac-hook-preupgrade
branch
from
6aa88ad to
27036c5
Compare
|
hey @liyinan926, done rebasing. Please approve running workflow |
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
Signed-off-by: York Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1379 (comment), a breaking change was introduced.
The result is that when I did a helm upgrade from 1.1.6 chart to a 1.1.10+ chart, the spark-operator ClusterRole and ClusterRoleBinding resources are deleted. also see: #1407
In this PR, I added pre-upgrade value to all 3 resources. Although it won't create the RBAC resources upon the 1st
helm upgradefrom the old chart(I think this is helm behavior), a secondhelm upgradewill apply the previously non-hook RBAC resources.