Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README - secrets and sidecars need mutating webhooks #1550

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

djdillon
Copy link
Contributor

Like Init-Containers, Sidecars require mutating admission webhooks to work.

Like Init-Containers, Sidecars require mutating admission webhooks to work.
@google-cla
Copy link

google-cla bot commented Jun 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@djdillon djdillon changed the title Update README - specify sidecars needing mutating webhooks Update README - secrets and sidecars need mutating webhooks Jun 15, 2022
@liyinan926 liyinan926 merged commit 94775cd into kubeflow:master Jun 15, 2022
@djdillon djdillon deleted the patch-1 branch June 16, 2022 18:37
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
…#1550)

* Update README - specify sidecars needing mutating webhooks

Like Init-Containers, Sidecars require mutating admission webhooks to work.

* Also update for mounting secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants