Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingressClassName chart value #1610

Closed
wants to merge 5 commits into from

Conversation

vpbarb
Copy link

@vpbarb vpbarb commented Sep 5, 2022

This PR adds the controller option ingress-class-name value in the Helm chart values.

The option was implemented here: #1482

@vpbarb vpbarb closed this Sep 16, 2022
@vpbarb vpbarb reopened this Nov 11, 2022
@vpbarb vpbarb closed this Nov 23, 2022
@fei819 fei819 mentioned this pull request Dec 13, 2023
@a-shkarupin
Copy link

@vpbarb could you please help me understand why this was closed?
I'm currently having issues setting ingress class name and this looked like a solution, so I'm confused why this didn't make it. Is there an alternative way out there?

@vpbarb
Copy link
Author

vpbarb commented Aug 9, 2024

@vpbarb could you please help me understand why this was closed? I'm currently having issues setting ingress class name and this looked like a solution, so I'm confused why this didn't make it. Is there an alternative way out there?

@a-shkarupin I made this PR before the spark-operator maintenance was moved to Kubeflow. I waited for 3 months for some feedback and realized that it would not be merged. So I closed the PR. I ended up having a fork used internally for our company needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants