Fix #1393 : fix tolerations block in wrong segment for webhook jobs #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be merged? Currently needing to run a patch just to set nodeselectors |
ImpSy
pushed a commit
to spotinst/spark-on-k8s-operator
that referenced
this pull request
Jul 27, 2023
ImpSy
pushed a commit
to spotinst/spark-on-k8s-operator
that referenced
this pull request
Jul 31, 2023
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #1393 , this will ensure the tolerations block are within the if-block of the helm chart manifests for the Job resources.
Tested with
helm templateand tolerations set.