feat: add support for custom service labels

[Cian911]

There is no way currently to add custom labels to services created by the spark-operator. This can be very useful for anyone who uses opa-gatekeeper for policy controls in their kubernetes clusters.

See related issues of users asking for this: #1342

[yuchaoran2011]

Thanks for the contribution. Indentation has issues. Please make sure to run go fmt to reformat the code. serviceLabels sounds generic. Can we make it clear by renaming it to something like sparkUiSvcLabels?

[Cian911]

Thanks for the contribution. Indentation has issues. Please make sure to run go fmt to reformat the code. serviceLabels sounds generic. Can we make it clear by renaming it to something like sparkUiSvcLabels?

@yuchaoran2011 Thanks for taking a look, and the quick response. I have pushed a fix for the formatting 👍

However, with regards to renaming serviceLabels, I'm not sure I agree. The change I made, I feel, is adhering to the naming already in place for other attributes on the SparkUIConfiguration struct: see here.

I can make this change if insisted, but I personally don't see the benefit in the following configuration (as this suggestion might entail):

sparkUIOptions:
    sparkUiSvcLabels:
      test-label/v1: 'true'

vs

sparkUIOptions:
    serviceLabels:
      test-label/v1: 'true'

[yuchaoran2011]

You are right. I missed that the newly added serviceLabels is under UI configurations. That's good then. One last change: another PR got merged before yours that took the 1.1.29 version number, now the chart number needs to be bump up to 1.1.30

[Cian911]

@yuchaoran2011 Done :)

[yuchaoran2011]

/lgtm

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cian911, yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yuchaoran2011]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment