Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish chart independently, incremented both chart and image versions to trigger build of both #1964

Merged

Conversation

AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Apr 12, 2024

moved chart publishing to a separate job which runs after publish image is skipped or succeeded

@AndrewChubatiuk AndrewChubatiuk changed the title publish chart independently, incremented both chart and image version… publish chart independently, incremented both chart and image versions to trigger build of both Apr 12, 2024
…s to trigger build of both

Signed-off-by: Andrew Chubatiuk <[email protected]>
@AndrewChubatiuk AndrewChubatiuk force-pushed the publish-chart-independently branch from 8d38ad7 to 1c0794b Compare April 12, 2024 04:50
Signed-off-by: Andrew Chubatiuk <[email protected]>
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewChubatiuk, vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 76a7947 into kubeflow:master Apr 13, 2024
7 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the publish-chart-independently branch April 13, 2024 15:22
peter-mcclonski pushed a commit to TechnologyBrewery/spark-on-k8s-operator that referenced this pull request Apr 16, 2024
…s to trigger build of both (kubeflow#1964)

* publish chart independently, incremented both chart and image versions to trigger build of both

Signed-off-by: Andrew Chubatiuk <[email protected]>

* bump chart version

Signed-off-by: Andrew Chubatiuk <[email protected]>

---------

Signed-off-by: Andrew Chubatiuk <[email protected]>
Signed-off-by: Peter McClonski <[email protected]>
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
…s to trigger build of both (kubeflow#1964)

* publish chart independently, incremented both chart and image versions to trigger build of both

Signed-off-by: Andrew Chubatiuk <[email protected]>

* bump chart version

Signed-off-by: Andrew Chubatiuk <[email protected]>

---------

Signed-off-by: Andrew Chubatiuk <[email protected]>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
…s to trigger build of both (kubeflow#1964)

* publish chart independently, incremented both chart and image versions to trigger build of both

Signed-off-by: Andrew Chubatiuk <[email protected]>

* bump chart version

Signed-off-by: Andrew Chubatiuk <[email protected]>

---------

Signed-off-by: Andrew Chubatiuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants