-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove k8s.io/kubernetes replaces and adapt to v1.29.3 apis #1968
Conversation
Signed-off-by: ajayk <[email protected]>
/assign @vara-bonthu |
@ajayk, it looks like the PR description is missing. Could you please provide more details to help us review your changes effectively? Purpose of the Change: Why is this change necessary? Thank you for contributing, and we look forward to your detailed response! |
@vara-bonthu It seems to me that while upgrading the k8s.io/kubernetes module version in PR: #1630 the person missed removing the replace statement present in go.mod file for Kubernetes Line 161 in 6ded3ac
For this reason, even after Updating the module version in #1630 #1954, it is set to version 1.19.6, Which is 10 versions older than the current one 1.29.3 link. This older version of Kubernetes has multiple CVE present in it. just removing the replace line doesn't fix as there is a version mismatch with some other go modules this PR try to fix those with minimal changes. |
/approve Thanks for the details @debasishbsws ! It does make sense @yuchaoran2011 Please review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! /lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajayk, vara-bonthu, yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…ubeflow#1968) Signed-off-by: ajayk <[email protected]>
…ubeflow#1968) Signed-off-by: ajayk <[email protected]>
No description provided.