feat: Doc updates, Issue and PR templates are added #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the workflow is failed due to the bug introduced by recent PRs. Ignore this and this will be addressed in the next PR. @AndrewChubatiuk Are you aware of this workflow? 
|
|
@vara-bonthu fixed it in my PR. this PR has only changes in README.md, but has no changes in README.md template. workflow validates if there are changes in README.md after |
|
@vara-bonthu Just run |
|
@ChenYi015 It might be beneficial to include the |
Agree, I will do it. |
Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>
…elines Signed-off-by: Vara Bonthu <[email protected]>
…low guidelines" This reverts commit b892f5c. Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Andrew Chubatiuk <[email protected]> Signed-off-by: Vara Bonthu <[email protected]>
Signed-off-by: Vara Bonthu <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vara-bonthu, yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
peter-mcclonski
pushed a commit
to TechnologyBrewery/spark-on-k8s-operator
that referenced
this pull request
Apr 16, 2024
* Issue templates are added to the repo Signed-off-by: Vara Bonthu <[email protected]> * removed Google CLA requirement Signed-off-by: Vara Bonthu <[email protected]> * Updated ghcr.io registry references in the workflow Signed-off-by: Vara Bonthu <[email protected]> * Added Pull request template Signed-off-by: Vara Bonthu <[email protected]> * Updated Main README.md with Kubeflow header and new Slack channel link Signed-off-by: Vara Bonthu <[email protected]> * Removed the License header and it will be replaced with Kubeflow guidelines Signed-off-by: Vara Bonthu <[email protected]> * Revert "Removed the License header and it will be replaced with Kubeflow guidelines" This reverts commit b892f5c. Signed-off-by: Vara Bonthu <[email protected]> * Readme line revert for gcp docs Signed-off-by: Vara Bonthu <[email protected]> * pre-commit run -a updates Signed-off-by: Vara Bonthu <[email protected]> * fixed the helm lint issue by upgrading the Helm chart version Signed-off-by: Vara Bonthu <[email protected]> * fixed docker image tag and updated chart docs (kubeflow#1969) Signed-off-by: Andrew Chubatiuk <[email protected]> Signed-off-by: Vara Bonthu <[email protected]> * rebase from master Signed-off-by: Vara Bonthu <[email protected]> --------- Signed-off-by: Vara Bonthu <[email protected]> Signed-off-by: Andrew Chubatiuk <[email protected]> Co-authored-by: Andrii Chubatiuk <[email protected]> Signed-off-by: Peter McClonski <[email protected]>
sigmarkarl
pushed a commit
to spotinst/spark-on-k8s-operator
that referenced
this pull request
Aug 7, 2024
* Issue templates are added to the repo Signed-off-by: Vara Bonthu <[email protected]> * removed Google CLA requirement Signed-off-by: Vara Bonthu <[email protected]> * Updated ghcr.io registry references in the workflow Signed-off-by: Vara Bonthu <[email protected]> * Added Pull request template Signed-off-by: Vara Bonthu <[email protected]> * Updated Main README.md with Kubeflow header and new Slack channel link Signed-off-by: Vara Bonthu <[email protected]> * Removed the License header and it will be replaced with Kubeflow guidelines Signed-off-by: Vara Bonthu <[email protected]> * Revert "Removed the License header and it will be replaced with Kubeflow guidelines" This reverts commit b892f5c. Signed-off-by: Vara Bonthu <[email protected]> * Readme line revert for gcp docs Signed-off-by: Vara Bonthu <[email protected]> * pre-commit run -a updates Signed-off-by: Vara Bonthu <[email protected]> * fixed the helm lint issue by upgrading the Helm chart version Signed-off-by: Vara Bonthu <[email protected]> * fixed docker image tag and updated chart docs (kubeflow#1969) Signed-off-by: Andrew Chubatiuk <[email protected]> Signed-off-by: Vara Bonthu <[email protected]> * rebase from master Signed-off-by: Vara Bonthu <[email protected]> --------- Signed-off-by: Vara Bonthu <[email protected]> Signed-off-by: Andrew Chubatiuk <[email protected]> Co-authored-by: Andrii Chubatiuk <[email protected]>
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
* Issue templates are added to the repo Signed-off-by: Vara Bonthu <[email protected]> * removed Google CLA requirement Signed-off-by: Vara Bonthu <[email protected]> * Updated ghcr.io registry references in the workflow Signed-off-by: Vara Bonthu <[email protected]> * Added Pull request template Signed-off-by: Vara Bonthu <[email protected]> * Updated Main README.md with Kubeflow header and new Slack channel link Signed-off-by: Vara Bonthu <[email protected]> * Removed the License header and it will be replaced with Kubeflow guidelines Signed-off-by: Vara Bonthu <[email protected]> * Revert "Removed the License header and it will be replaced with Kubeflow guidelines" This reverts commit b892f5c. Signed-off-by: Vara Bonthu <[email protected]> * Readme line revert for gcp docs Signed-off-by: Vara Bonthu <[email protected]> * pre-commit run -a updates Signed-off-by: Vara Bonthu <[email protected]> * fixed the helm lint issue by upgrading the Helm chart version Signed-off-by: Vara Bonthu <[email protected]> * fixed docker image tag and updated chart docs (kubeflow#1969) Signed-off-by: Andrew Chubatiuk <[email protected]> Signed-off-by: Vara Bonthu <[email protected]> * rebase from master Signed-off-by: Vara Bonthu <[email protected]> --------- Signed-off-by: Vara Bonthu <[email protected]> Signed-off-by: Andrew Chubatiuk <[email protected]> Co-authored-by: Andrii Chubatiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Changes Included:
README Update: The main README.md now features the Kubeflow header and includes a new link to our updated Slack channel, facilitating better community engagement.
PR Template Addition: Added a new pull request template to the .github folder to streamline future contributions.
Workflow Update: Updated references to the container registry in our GitHub workflows to use ghcr.io, ensuring consistency with our current infrastructure.
Contributing Guidelines Revision: Removed the requirement for Google CLA from our contributing guidelines to simplify the contribution process.
Issue Templates Creation: Created new issue templates for Bugs, Features, and Questions to organize and prioritize incoming issues more efficiently.