Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Github workflow to publish Helm charts on chart changes, irrespective of image change #1992

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Apr 18, 2024

🛑 Important:

Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!

For guidelines on how to contribute, please review the CONTRIBUTING.md document.

Purpose of this PR

Provide a clear and concise description of the changes. Explain the motivation behind these changes and link to relevant issues or discussions.

This pull request introduces modifications to the CI/CD process, ensuring the autonomous publication of Helm charts regardless of image update status. The motivation for these changes is to streamline the release process by allowing updates to Helm charts to be published even when no corresponding image changes have occurred.

Proposed changes:
- Altered the GitHub Actions workflow to facilitate the independent release of Helm charts without the necessity of concurrent image update

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

#1994

@vara-bonthu
Copy link
Contributor Author

@AndrewChubatiuk @yuchaoran2011 FYI...

Copy link
Contributor

@yuchaoran2011 yuchaoran2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu, yuchaoran2011

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [vara-bonthu,yuchaoran2011]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4d4f1c5 into kubeflow:master Apr 19, 2024
7 checks passed
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
…irrespective of image change (kubeflow#1992)

* Update workflow to publish Helm charts on chart changes, irrespective of image updates

Signed-off-by: Vara Bonthu <[email protected]>

* fixed the chart name with prefix

Signed-off-by: Vara Bonthu <[email protected]>

---------

Signed-off-by: Vara Bonthu <[email protected]>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
…irrespective of image change (kubeflow#1992)

* Update workflow to publish Helm charts on chart changes, irrespective of image updates

Signed-off-by: Vara Bonthu <[email protected]>

* fixed the chart name with prefix

Signed-off-by: Vara Bonthu <[email protected]>

---------

Signed-off-by: Vara Bonthu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants