-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minikube version in CI #2059
Conversation
Signed-off-by: Cian Gallagher <[email protected]>
cc: @andreyvelich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this issue due to a version mismatch for Minikube or image caching problems? Did you try testing this in your fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vara-bonthu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* controller introduce - map of queues per spark app * Add MemoryLimit as option that will override spark pods limits (by using webhook) * Add qps and burst as a parameter * Add profiling option and export-pprof.sh script * Update minikube version in CI (kubeflow#2059) Signed-off-by: Cian Gallagher <[email protected]> * Adding an option to set the priority class for spark-operator pod (kubeflow#2043) * feat: give an option to set the priority class for spark-operator pod Signed-off-by: Praveen Gajulapalli <[email protected]> * feat: bumped up helm chart version Signed-off-by: Praveen Gajulapalli <[email protected]> * fix: fixed issue with position of priorityClassName Signed-off-by: Praveen Gajulapalli <[email protected]> * Update api-docs, README.md and chart values Signed-off-by: bentzi <[email protected]> --------- Signed-off-by: Cian Gallagher <[email protected]> Signed-off-by: bentzi <[email protected]> Co-authored-by: Cian Gallagher <[email protected]> Co-authored-by: Praveen Gajulapalli <[email protected]>
Signed-off-by: Cian Gallagher <[email protected]>
Signed-off-by: Cian Gallagher <[email protected]>
Signed-off-by: Cian Gallagher <[email protected]>
🛑 Important:
Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!
For guidelines on how to contribute, please review the CONTRIBUTING.md document.
Purpose of this PR
Following on from discussion here, this PR intends to update the
minikube
version in CI to the latest. This is to fix an issue on the current version of minikube in use.Proposed changes:
minikube
action to latest version -2.11.0
, as well as the minikube version.Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
Checklist
Before submitting your PR, please review the following:
Additional Notes