Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minikube version in CI #2059

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

Cian911
Copy link
Contributor

@Cian911 Cian911 commented Jun 13, 2024

🛑 Important:

Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!

For guidelines on how to contribute, please review the CONTRIBUTING.md document.

Purpose of this PR

Following on from discussion here, this PR intends to update the minikube version in CI to the latest. This is to fix an issue on the current version of minikube in use.

Proposed changes:

  • Update minikube action to latest version - 2.11.0, as well as the minikube version.

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@Cian911
Copy link
Contributor Author

Cian911 commented Jun 15, 2024

cc: @andreyvelich

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue due to a version mismatch for Minikube or image caching problems? Did you try testing this in your fork?

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8f7e325 into kubeflow:master Jun 15, 2024
6 of 7 checks passed
bnetzi added a commit to bnetzi/spark-operator that referenced this pull request Jun 16, 2024
* controller introduce - map of queues per spark app

* Add MemoryLimit as option that will override spark pods limits (by using webhook)

* Add qps and burst as a parameter

* Add profiling option and export-pprof.sh script

* Update minikube version in CI (kubeflow#2059)

Signed-off-by: Cian Gallagher <[email protected]>

* Adding an option to set the priority class for spark-operator pod (kubeflow#2043)

* feat: give an option to set the priority class for spark-operator pod
Signed-off-by: Praveen Gajulapalli <[email protected]>

* feat: bumped up helm chart version
Signed-off-by: Praveen Gajulapalli <[email protected]>

* fix: fixed issue with position of priorityClassName
Signed-off-by: Praveen Gajulapalli <[email protected]>

* Update api-docs, README.md and chart values

Signed-off-by: bentzi <[email protected]>

---------

Signed-off-by: Cian Gallagher <[email protected]>
Signed-off-by: bentzi <[email protected]>
Co-authored-by: Cian Gallagher <[email protected]>
Co-authored-by: Praveen Gajulapalli <[email protected]>
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants