Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code of conduct and update contributor guide #2074

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

ChenYi015
Copy link
Contributor

@ChenYi015 ChenYi015 commented Jun 25, 2024

Purpose of this PR

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@ChenYi015
Copy link
Contributor Author

/assign @vara-bonthu

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this document @ChenYi015!
I left a few comments.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just link to existing docs from the website/community.

@google-oss-prow google-oss-prow bot added size/S and removed size/M labels Jun 25, 2024
@ChenYi015 ChenYi015 changed the title Add CNCF Code of conduct Add code of conduct and update contributor guide Jun 25, 2024
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 26, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4bb4b5c into kubeflow:master Jun 26, 2024
7 checks passed
YanivKunda pushed a commit to YanivKunda/spark-operator that referenced this pull request Jul 4, 2024
* Add CNCF Code of Conduct

Signed-off-by: Yi Chen <[email protected]>

* Update contributing guide

Signed-off-by: Yi Chen <[email protected]>

* Redirect links to kubeflow website

Signed-off-by: Yi Chen <[email protected]>

---------

Signed-off-by: Yi Chen <[email protected]>
Signed-off-by: Yaniv Kunda <[email protected]>
@ChenYi015 ChenYi015 deleted the code-of-conduct branch July 18, 2024 09:27
jacobsalway pushed a commit to jacobsalway/spark-operator that referenced this pull request Jul 25, 2024
* Add CNCF Code of Conduct

Signed-off-by: Yi Chen <[email protected]>

* Update contributing guide

Signed-off-by: Yi Chen <[email protected]>

* Redirect links to kubeflow website

Signed-off-by: Yi Chen <[email protected]>

---------

Signed-off-by: Yi Chen <[email protected]>
sigmarkarl pushed a commit to spotinst/spark-on-k8s-operator that referenced this pull request Aug 7, 2024
* Add CNCF Code of Conduct

Signed-off-by: Yi Chen <[email protected]>

* Update contributing guide

Signed-off-by: Yi Chen <[email protected]>

* Redirect links to kubeflow website

Signed-off-by: Yi Chen <[email protected]>

---------

Signed-off-by: Yi Chen <[email protected]>
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
* Add CNCF Code of Conduct

Signed-off-by: Yi Chen <[email protected]>

* Update contributing guide

Signed-off-by: Yi Chen <[email protected]>

* Redirect links to kubeflow website

Signed-off-by: Yi Chen <[email protected]>

---------

Signed-off-by: Yi Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants