Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test image build broken #233

Closed
kunmingg opened this issue Oct 8, 2018 · 6 comments · Fixed by #236
Closed

test image build broken #233

kunmingg opened this issue Oct 8, 2018 · 6 comments · Fixed by #236
Labels
0.4.0 priority/p1

Comments

@kunmingg
Copy link
Contributor

kunmingg commented Oct 8, 2018

How to reproduce: build image with
docker build --no-cache ...

related:
pypa/pipenv#2924
@kunmingg
Copy link
Contributor Author

kunmingg commented Oct 8, 2018

@jlewi
@richardsliu

@richardsliu
Copy link
Contributor

Did you try the workaround mentioned in the link?

@kunmingg
Copy link
Contributor Author

kunmingg commented Oct 8, 2018

Doesn't work

@kunmingg
Copy link
Contributor Author

@jlewi
@r2d4

@jlewi
Copy link
Contributor

jlewi commented Oct 17, 2018

I think just pinnning the pip version works

RUN pip3 install pipenv==2018.10.9

@jlewi
Copy link
Contributor

jlewi commented Oct 17, 2018 •
edited
Loading

Pushing the image I see.

I think I've hit this before

ERROR: Error during upload of: gcr.io/kubeflow-releasing/worker:v20181017-bfeaaf5-dirty-ab8665
ERROR: gcloud crashed (UnicodeDecodeError): 'utf8' codec can't decode byte 0x8b in position 1: invalid start byte

Seems like a problem with add-tag

gcloud container images add-tag --quiet gcr.io/kubeflow-ci/test-worker:v20181017-bfeaaf5-dirty-ab8665 gcr.io/kubeflow-releasing/worker:v20181017-bfeaaf5-dirty-ab8665 --verbosity=info

jlewi added a commit to jlewi/testing that referenced this issue Oct 17, 2018
@jlewi
Fix build of test worker image.
e7ceef6 
* Need to pin version of pipenv to a newer version to fix the bux.

Fix kubeflow#233
@jlewi jlewi mentioned this issue Oct 17, 2018
Merged
k8s-ci-robot pushed a commit that referenced this issue Oct 18, 2018
@jlewi @k8s-ci-robot
Fix build of test worker image. (#236)
5408627 
* Need to pin version of pipenv to a newer version to fix the bux.

Fix #233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.4.0 priority/p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build of test worker image. jlewi/testing
3 participants
@jlewi @kunmingg @richardsliu