Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of date docs: Using Your Own Domain #1166

Closed
apshoemaker opened this issue Sep 23, 2019 · 4 comments · Fixed by #1650
Closed

Out of date docs: Using Your Own Domain #1166

apshoemaker opened this issue Sep 23, 2019 · 4 comments · Fixed by #1650
Assignees
@fediazgon
Labels
area/docs doc-sprint Issues to work on during the Kubeflow Doc Sprint kind/bug priority/p2

Comments

@apshoemaker
Copy link

https://www.kubeflow.org/docs/gke/custom-domain/

This page is very out of date. I have not spent enough constructive time to figure this out on my own, but this does not seem consistent with the current project setup in 0.6 or 0.7.
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@apshoemaker
Copy link
Author

It appears from some output in coordinator.go that the customization is done in app.yaml prior to kfctl generate. Does that sound right?

@sarahmaddox sarahmaddox added the doc-sprint Issues to work on during the Kubeflow Doc Sprint label Jan 2, 2020
@sarahmaddox sarahmaddox mentioned this issue Jan 2, 2020
Closed
@sarahmaddox sarahmaddox changed the title Using Your Own Domain Out of date docs: Using Your Own Domain Jan 2, 2020
@jtfogarty
Copy link

jtfogarty commented Jan 5, 2020 •
edited
Loading

/area docs
/priority p2
/kind bug

@fediazgon
Copy link
Contributor

I'm taking this one!

/assign @fediazgon

fediazgon added a commit to fediazgon/website that referenced this issue Feb 11, 2020
@fediazgon
Update 'Using your own domain' (kubeflow#1166)
554783f
@fediazgon fediazgon mentioned this issue Feb 11, 2020
Merged
fediazgon added a commit to fediazgon/website that referenced this issue Feb 11, 2020
@fediazgon
Update 'Using your own domain' (kubeflow#1166)
8d0d70c
fediazgon added a commit to fediazgon/website that referenced this issue Feb 11, 2020
@fediazgon
Update 'Using your own domain' (kubeflow#1166)
ee373a7
fediazgon added a commit to fediazgon/website that referenced this issue Feb 11, 2020
@fediazgon
Update 'Using your own domain' (kubeflow#1166)
24a4bec
k8s-ci-robot pushed a commit that referenced this issue Feb 11, 2020
@fediazgon
Update 'Using your own domain' (#1166) (#1650)
200de17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fediazgon fediazgon

Labels
area/docs doc-sprint Issues to work on during the Kubeflow Doc Sprint kind/bug priority/p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update 'Using your own domain' (#1166) fediazgon/website
6 participants
@apshoemaker @jlewi @sarahmaddox @jtfogarty @fediazgon @k8s-ci-robot