Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples page to show which version of Kubelow each sample works with #1316

Closed
jlewi opened this issue Nov 4, 2019 · 14 comments
Closed
Assignees
Labels
area/docs doc-sprint Issues to work on during the Kubeflow Doc Sprint effort/3-days help wanted Extra attention is needed kind/bug kind/feature priority/p0

Comments

@jlewi
Copy link
Contributor

jlewi commented Nov 4, 2019

This page
https://www.kubeflow.org/docs/examples/kubeflow-samples/

lists a lot of samples that I don't think are updated for 0.7.

  • Should we remove samples until they have been updated for 0.7?

  • Should we add the xgboost_synthetic ?

    • That is probably the sample most up to date for 0.7
  • code_search is pretty stale at this point as are some other samples so we should probably remove that one.

  • I think @amygdala might have made some updates to github issue summarization recently

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.54. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor Author

jlewi commented Nov 4, 2019

@sarahmaddox suggested not removing the list of samples but instead with each one listing the Kubeflow versions they work with.

@sarahmaddox
Copy link
Contributor

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@sarahmaddox:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 4, 2019
@janeman98
Copy link
Contributor

@sarahmaddox Is there an easy way to find out what version these sample work with?

I have a quick look on these samples, most of them just point to "Getting Started with Kubeflow"
Semantic code search -- > Getting Started with Kubeflow (https://www.kubeflow.org/docs/started/getting-started/)
Financial time series --> KUBEFLOW_VERSION=0.2.5 ??
GitHub issue summarization --> v0.4.0-rc.2.
MNIST image classification -- > Getting Started with Kubeflow
Object detection - cats and dogs -- > Getting Started with Kubeflow
PyTorch MNIST --> Getting Started with Kubeflow
Ames housing value prediction --> Getting Started with Kubeflow

@sarahmaddox
Copy link
Contributor

@texasmichelle and @amygdala Can you help identify the Kubeflow version for each sample?

@amygdala
Copy link
Contributor

amygdala commented Nov 9, 2019

I should have some time to tackle it week after next. (Most aren't "mine" and I don't know their current status).
The github summarization/pipelines one is mine, and has been updated to work with 0.7. (Note: that's the pipelines subdir of that example.)

@sarahmaddox sarahmaddox added doc-sprint Issues to work on during the Kubeflow Doc Sprint and removed good first issue Good for newcomers labels Jan 2, 2020
@hefedev
Copy link
Contributor

hefedev commented Feb 7, 2020

I'd like to jump on this one if possible.
To figure out which version works, I'll look at the CONFIG_FILE url and which master branch it points towards. This always worked for me before.

@sarahmaddox
Copy link
Contributor

/assign @hefedev

Thanks @hefedev!

@sarahmaddox sarahmaddox changed the title [0.7] Update samples page for 0.7 Update samples page to show which version of Kubelow each sample works with Feb 7, 2020
@sarahmaddox
Copy link
Contributor

@hefedev I've moved this issue to In progress in the doc sprint Kanban board, because the issue is assigned to you. Happy sprinting!

@hefedev
Copy link
Contributor

hefedev commented Feb 8, 2020

Thank you @sarahmaddox for the opportunity, I submitted my first changes for feedback. I'll get back on this asap.

@amygdala
Copy link
Contributor

amygdala commented Feb 10, 2020

I'm not sure this should be closed yet? I believe we're still testing many of these examples with the KF 1 RC. @jlewi @sarahmaddox
cc @velascoluis, who is helping with this.

@sarahmaddox
Copy link
Contributor

Thanks @amygdala that's excellent news. Let's keep this issue as closed, because it originally related to v0.7 and because @hefedev has implemented a solution using Hugo block parameters and the GitHub API.

How about raising another issue for v1.0. If we need to manually override the results from the API, we can do that via the parameters that feed into the block.

@amygdala
Copy link
Contributor

amygdala commented Feb 10, 2020

Just a note so it doesn't get lost: https://github.com/kubeflow/examples/blob/master/pipelines/mnist-pipelines/mnist_pipeline.py turns out to be broken (in 0.7 too, I believe, given the nature of the probs).

I think Jeremy did create such an issue for 1.0 already; let me confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs doc-sprint Issues to work on during the Kubeflow Doc Sprint effort/3-days help wanted Extra attention is needed kind/bug kind/feature priority/p0
Projects
None yet
Development

No branches or pull requests

6 participants