-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samples page to show which version of Kubelow each sample works with #1316
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
@sarahmaddox suggested not removing the list of samples but instead with each one listing the Kubeflow versions they work with. |
/good-first-issue |
@sarahmaddox: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sarahmaddox Is there an easy way to find out what version these sample work with? I have a quick look on these samples, most of them just point to "Getting Started with Kubeflow" |
@texasmichelle and @amygdala Can you help identify the Kubeflow version for each sample? |
I should have some time to tackle it week after next. (Most aren't "mine" and I don't know their current status). |
I'd like to jump on this one if possible. |
@hefedev I've moved this issue to In progress in the doc sprint Kanban board, because the issue is assigned to you. Happy sprinting! |
Thank you @sarahmaddox for the opportunity, I submitted my first changes for feedback. I'll get back on this asap. |
I'm not sure this should be closed yet? I believe we're still testing many of these examples with the KF 1 RC. @jlewi @sarahmaddox |
Thanks @amygdala that's excellent news. Let's keep this issue as closed, because it originally related to v0.7 and because @hefedev has implemented a solution using Hugo block parameters and the GitHub API. How about raising another issue for v1.0. If we need to manually override the results from the API, we can do that via the parameters that feed into the block. |
Just a note so it doesn't get lost: https://github.com/kubeflow/examples/blob/master/pipelines/mnist-pipelines/mnist_pipeline.py turns out to be broken (in 0.7 too, I believe, given the nature of the probs). I think Jeremy did create such an issue for 1.0 already; let me confirm. |
This page
https://www.kubeflow.org/docs/examples/kubeflow-samples/
lists a lot of samples that I don't think are updated for 0.7.
Should we remove samples until they have been updated for 0.7?
Should we add the xgboost_synthetic ?
code_search is pretty stale at this point as are some other samples so we should probably remove that one.
I think @amygdala might have made some updates to github issue summarization recently
The text was updated successfully, but these errors were encountered: