Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fairing section #3722

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

80rian
Copy link
Contributor

@80rian 80rian commented Apr 25, 2024

Resolves: #3721

Removing Fairing link as Fairing pages are removed from #3553.

Resolves: kubeflow#3721

Signed-off-by: Adrian Jeong <[email protected]>
Copy link

Hi @80rian. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot requested review from alfsuse and knkski April 25, 2024 00:27
@80rian 80rian changed the title docs: Remove Fairing section Remove Fairing section Apr 25, 2024
@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rimolive
Copy link
Member

/approve

@rimolive
Copy link
Member

/cc @kubeflow/kubeflow-steering-committee

How can we proceed with documentation PRs? We have lots of OWNERS files spread in the repo, and only KSC members as the root OWNERS. If we want to ensure the Documentation phase can move on smoothly the Release Team need some autonomy to merge PRs.

Copy link

@rimolive: GitHub didn't allow me to request PR reviews from the following users: kubeflow/kubeflow-steering-committee.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kubeflow/kubeflow-steering-committee

How can we proceed with documentation PRs? We have lots of OWNERS files spread in the repo, and only KSC members as the root OWNERS. If we want to ensure the Documentation phase can move on smoothly the Release Team need some autonomy to merge PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 80rian, rimolive, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0dc5600 into kubeflow:master Apr 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Fairing" link from the Architecture document
4 participants