model registry: pin tag and standalone instructions #3740
Conversation
implements suggestions from KF community meeting 2024-05-22 Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
There was a problem hiding this comment.
Thanks for the update @tarilabs!
/lgtm
/assign @thesuperzapper
There was a problem hiding this comment.
Other than adding an OWNERS file like @andreyvelich said, I have a small number of comments that will improve the readability.
using same members from all owners file in KF/model-registry repo at this time Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]> Signed-off-by: Matteo Mortari <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
added with b8d14db , thank you 👍 |
|
@tarilabs this is a great improvement! I am sure we will continue to work on the installation guides as we progress to a beta/GA release, but these are fine until then. /lgtm @andreyvelich can you please approve this? |
thanks, and 💯 I always prefer iterative work, that also makes it easier to onboard feedback we received from community--as we're also doing 🚀 |
Signed-off-by: Matteo Mortari <[email protected]>
|
/lgtm @andreyvelich approve when ready |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
implements suggestions from KF community meeting 2024-05-22
for your kind review
/assign @andreyvelich @thesuperzapper
please?