Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubeflow diagrams with Spark Operator and Model Registry #3780

Merged

Conversation

andreyvelich
Copy link
Member

I updated Kubeflow diagrams with Spark Operator and Model Registry, since we already have these components on Kubeflow website.

/assign @kubeflow/wg-data-leads @kubeflow/kubeflow-steering-committee @vikas-saxena02

@google-oss-prow google-oss-prow bot requested review from alfsuse and knkski June 24, 2024 18:05
@rimolive
Copy link
Member

/lgtm

@tarilabs
Copy link
Member

Thank you so much @andreyvelich

In content/en/docs/started/images/kubeflow-intro-diagram.drawio.svg
I would suggest rename the in-parenthesis from:
(ML Metadata)
to:
(Model Metadata)

so to keep the generic scope intended by the parenthesis, and avoid potential confusion with the "MLMD" (library/project).

wdyt ?

@thesuperzapper
Copy link
Member

@andreyvelich I agree that we should say "Model Metadata" rather than "ML Metadata" (which is the name of an actual project that we use as a dependency: https://github.com/google/ml-metadata

Also, can you fix the alignment problem on the "Feast" square, it drives me crazy:

Screenshot 2024-06-24 at 15 53 44

@vikas-saxena02
Copy link
Contributor

great work @andreyvelich you just depicted my precise thoughts here.

/approve

@vikas-saxena02
Copy link
Contributor

/approve

Signed-off-by: Andrey Velichkevich <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 24, 2024
@andreyvelich
Copy link
Member Author

Sounds good, updated.
/assign @tarilabs @thesuperzapper

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thank you so much

@google-oss-prow google-oss-prow bot added the lgtm label Jun 25, 2024
@andreyvelich
Copy link
Member Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tarilabs, vikas-saxena02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 77fc392 into kubeflow:master Jun 25, 2024
6 checks passed
@andreyvelich andreyvelich deleted the add-spark-kubeflow-diagram branch June 25, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants