Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack external CCM #820

Merged
merged 11 commits into from
Mar 13, 2020
Merged

OpenStack external CCM #820

merged 11 commits into from
Mar 13, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Mar 10, 2020

What this PR does / why we need it:
Support for external CCM for OpenStack

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Ref #616

Added OpenStack external CCM

kron4eg added 4 commits March 10, 2020 16:09
@kron4eg
openstack terraform changes
380d79e 
* Make cluster private (no external IPs)
* Use bastion to access cluster
* Set hostnames explicitly

Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Start taking into account external flag for openstack
38d4499 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Deploy openstack external CCM
9ac99dd 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
reuse genClusterRoleBinding across different external CCMs
27dfdbe 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg kron4eg requested a review from xmudrii March 10, 2020 15:11
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 10, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2020
@kron4eg kron4eg mentioned this pull request Mar 10, 2020
Closed
@kron4eg
lint fixes
5edf6ea 
Signed-off-by: Artiom Diomin <[email protected]>
xmudrii
xmudrii approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
🎉 💯

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member Author

kron4eg commented Mar 11, 2020

/lgtm cancel

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020
@kron4eg
Fix e2e tests for openstack
aeda2ea 
Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg
Copy link
Member Author

kron4eg commented Mar 11, 2020

/test pull-kubeone-test

@kron4eg kron4eg force-pushed the openstack-external-ccm branch from dc445b9 to 2629d2f Compare March 11, 2020 23:11
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2020
@kron4eg
Copy link
Member Author

kron4eg commented Mar 12, 2020

/test pull-kubeone-test

@kron4eg
Copy link
Member Author

kron4eg commented Mar 12, 2020

/retest

1 similar comment
@kron4eg
Copy link
Member Author

kron4eg commented Mar 12, 2020

/retest

xmudrii
xmudrii approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2d8137066c80745bd6fc2f48b531d6c0c5d40dd5

@kubermatic-bot kubermatic-bot merged commit bd5ba7f into master Mar 13, 2020
@kubermatic-bot kubermatic-bot added this to the v0.12 milestone Mar 13, 2020
@kubermatic-bot kubermatic-bot deleted the openstack-external-ccm branch March 13, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.12
Development

Successfully merging this pull request may close these issues.
4 participants
@kron4eg @kubermatic-bot @kubermatic-triage-bot @xmudrii