Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release that re-includes the byline dependency #310

Closed
radu-matei opened this issue Jul 29, 2019 · 3 comments
Closed

New release that re-includes the byline dependency #310

radu-matei opened this issue Jul 29, 2019 · 3 comments

Comments

@radu-matei
Copy link
Contributor

#250 removed the dependency on byline and added json-stream. This change was part of all releases starting 0.9.0, including part of the latest release to date, 0.10.2.

However, 57f6c0b switched back from json-stream to byline, and since there is no release that contains this change, dependents that used byline who are updating this package from before 0.9 experience failure due to the missing package.

A new release based off mastershould mitigate this, and a workaround is to directly add "byline": "^5.0.0" as a dependency.

@drubin
Copy link
Contributor

drubin commented Jul 29, 2019

@radu-matei I am a little confused is your application is dependant on byline and upgrading to 0.10.2 broke because we removed byline and you were explicitly using it somewhere?

@radu-matei
Copy link
Contributor Author

Precisely - that being said, we should probably have explicitly declared it as a dependency (and did after upgrading the Kubernetes client, so this is not blocking in any way) - that being said, a new release would ensure that this doesn't break future upgrades from older versions that relied on byline.

@brendandburns
Copy link
Contributor

I'm going to close this. We're going to do a new release eventually, but I don't think that there's anything actionable other than "do a new release" which we will definitely get to eventually....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants