Update worker packages to address vulnerabilities #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-matei
requested review from
adamreese,
lukepatrick,
mumoshu,
technosophos and
vdice
as code owners
|
Deploy preview for brigade-docs ready! Built with commit 1d288c2 |
radu-matei
force-pushed
the
update-node-modules-audit
branch
2 times, most recently
from
b7dee2c to
453d4f2
Compare
vdice
approved these changes
Jul 30, 2019
lukepatrick
approved these changes
Jul 30, 2019
radu-matei
force-pushed
the
update-node-modules-audit
branch
from
3767042 to
f4f9379
Compare
Signed-off-by: Radu M <[email protected]> Update brigadier to 0.5.0 Signed-off-by: Radu M <[email protected]>
radu-matei
force-pushed
the
update-node-modules-audit
branch
from
f4f9379 to
1d288c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all Node modules with known vulnerabilities.
The update for
"@kubernetes/client-node": "^0.10.1"included some breaking changes (rename of the main module and an issue with the missingbylinedependency from the latest release - see kubernetes-client/javascript#310).Also closes #824 (running
yarn auditas part of the build pipeline).Seeing how this was in fact not that difficult, and
yarn auditseems to be a good fit, I'm also inclined to close #958.Related to this discussion is also #930, but I'd rather merge this to address the vulnerabilities, then decide on the Node modules.