Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spelling in README.md #1345

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix spelling in README.md #1345

merged 1 commit into from
Oct 17, 2023

Conversation

masonbrothers
Copy link
Contributor

Spelling Change from Namespcace to Namespace.

@masonbrothers
Update README.md
c767fc8 
Spelling Change
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 17, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: masonbrothers / name: Mason Brothers (c767fc8)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @masonbrothers!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2023
mstruebing
mstruebing approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 17, 2023
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, masonbrothers, mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9e504f6 into kubernetes-client:master Oct 17, 2023
5 checks passed
@snyk-deployer snyk-deployer mentioned this pull request May 24, 2024
Closed
@kat1906 kat1906 mentioned this pull request May 25, 2024
Closed
@armand-snyk armand-snyk mentioned this pull request May 30, 2024
Closed
@metju90 metju90 mentioned this pull request Jun 4, 2024
Closed
@Piyush-Bhor Piyush-Bhor mentioned this pull request Jun 18, 2024
Open
@VaniHaripriya VaniHaripriya mentioned this pull request Jun 25, 2024
Open
@paulsybrandy paulsybrandy mentioned this pull request Jul 7, 2024
Open
@minsiyang minsiyang mentioned this pull request Jul 20, 2024
Closed
@snyk-deployer snyk-deployer mentioned this pull request Jul 22, 2024
Closed
@jonnyowenpowell jonnyowenpowell mentioned this pull request Jul 25, 2024
Closed
@metju90 metju90 mentioned this pull request Jul 26, 2024
Closed
@jkopriva jkopriva mentioned this pull request Jul 29, 2024
Merged
@snyk-deployer snyk-deployer mentioned this pull request Jul 31, 2024
Closed
@snyk-deployer snyk-deployer mentioned this pull request Aug 8, 2024
Closed
@sawood14012 sawood14012 mentioned this pull request Aug 16, 2024
Open
@psturc psturc mentioned this pull request Sep 13, 2024
Open
@sawood14012 sawood14012 mentioned this pull request Sep 14, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstruebing mstruebing mstruebing approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@drubin drubin Awaiting requested review from drubin

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@masonbrothers @k8s-ci-robot @brendandburns @mstruebing