-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add generic and typed watch to KubernetesObjectApi #1831
add generic and typed watch to KubernetesObjectApi #1831
Conversation
1468cbd
to
cf4a11d
Compare
/assign mstruebing |
This looks good to me. Any chance that you can add unit tests? If not I'll do it as a follow up. |
Looks like CI/CD is failing for some reason. |
added some tests |
/assign @brendandburns |
This looks like a great PR, thanks! 🚀 /lgtm |
Co-authored-by: Max Strübing <[email protected]>
@mstruebing can you take another look? Do we have to port it to the release-1 branch? |
/lgtm Thanks for the PR. It would be appreciated (but not required) to port this to the 1.x branch also. Soon the 0.x branch will be deprecated and will be replaced by the 1.x branch. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, schrodit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow up of #1705 (comment)