Fix cp promise returns by converting the exec callbacks into promises

[joeferner]

Addresses issue #1767

Wraps the exec in a promise properly such that awaiting the promise will only return after the file is copied

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: joeferner / name: Joe Ferner (3eeb3e9, 4117590)

[k8s-ci-robot]

Welcome @joeferner!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

Thanks for the PR! Can you add a unit test demonstrating the problem as well so that we can be sure this fix works (and that it stays fixed)

[joeferner]

enhanced unit tests for both cpFromPod and cpToPod to test both the promises and that the data send/received was correct. Also deleted the temporary file created when running cpToPod

[mstruebing]

Thansk for the PR 🚀
Only one very minor comment, otherwise this looks like a solid PR to me.

[mstruebing]

/lgtm
/approve

Thanks for this PR 🚀

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joeferner, mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mstruebing]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment