-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test against node 22 #1890
ci: test against node 22 #1890
Conversation
Node 22 will become LTS in October 2024 Refs: https://github.com/nodejs/release
Welcome @cjihrig! |
Thank you for the PR. I actually think it would be a good idea to remove node 16, will wait for @brendanburns to confirm it's okay to remove. In the meanwhile - could you make the same change in the |
Sure - #1892 |
Yeah, let's remove node 16 |
Should I target both |
Both please! :) |
Node 16 has been EOL. This commit removes it from the CI matrix.
I pushed the Node 16 changes to this PR and #1892 as separate commits so that they can be merged at the same time without introducing conflicts. |
/lgtm Thanks 🚀 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjihrig, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Node 22 will become LTS in October 2024
Refs: https://github.com/nodejs/release
On a related note, Node 16 has been EOL for over a year. I'd be happy to remove it if the project wishes to do so.