Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-client/src: change license from Unlicense to Apache-2.0 #61

Merged

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jul 16, 2018

Part of kubernetes/sig-release#223 and kubernetes/steering#57:

In the kubernetes-client javascript repo, a package.json file was added stating that the kubernetes-client-typescript package is under the Unlicense. Can this be corrected to Apache-2.0?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2018
@nikhita
Copy link
Member Author

nikhita commented Jul 16, 2018

/cc @brendanburns @justaugustus
/assign @brendanburns

@k8s-ci-robot
Copy link
Contributor

@nikhita: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes-client members and repo collaborators can be assigned.

In response to this:

/cc @brendanburns @justaugustus
/assign @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@nikhita: GitHub didn't allow me to request PR reviews from the following users: brendanburns, justaugustus.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @brendanburns @justaugustus
/assign @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

/lgtm
/cc @brendandburns
/assign @brendandburns

@k8s-ci-robot
Copy link
Contributor

@justaugustus: changing LGTM is restricted to assignees, and only kubernetes-client/javascript repo collaborators may be assigned issues.

In response to this:

/lgtm
/cc @brendandburns
/assign @brendandburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brendandburns brendandburns merged commit a460160 into kubernetes-client:master Jul 20, 2018
@nikhita nikhita deleted the change-license-to-apache-2.0 branch August 8, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants