Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list custom object for all namespaces #1377

Closed
saswatac opened this issue Feb 13, 2021 · 7 comments
Closed

list custom object for all namespaces #1377

saswatac opened this issue Feb 13, 2021 · 7 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@saswatac
Copy link

What is the feature and why do you need it:

Similar to the core_v1_api, the custom_objects_api should have a method list_custom_object_for_all_namespaces

Describe the solution you'd like to see:

list_custom_object_for_all_namespaces calls endpoint /apis/{group}/{version}/{plural} to get custom objects in all namespaces.

@saswatac saswatac added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 13, 2021
@saswatac saswatac changed the title Custom resources list custom object for all namespaces Feb 13, 2021
@roycaihw
Copy link
Member

roycaihw commented Mar 1, 2021

/assign

@roycaihw
Copy link
Member

roycaihw commented Mar 1, 2021

@k8s-ci-robot
Copy link
Contributor

@roycaihw: Closing this issue.

In response to this:

I think https://github.com/kubernetes-client/python/blob/master/kubernetes/docs/CustomObjectsApi.md#list_cluster_custom_object is what you want.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jparklab
Copy link

jparklab commented Apr 26, 2021

@roycaihw list_cluster_custom_object is to list cluster scoped custom objects, and the request is to have list_custom_object_for_all_namespaces similar to list_service_for_all_namespaces for services.

Can you please reopen the issue? It would be nice if python client supports listing namespace scoped custom objects in all namespaces.

FYI, java client has a similar issue: kubernetes-client/java#941

@jparklab
Copy link

Please disregard my comment above. list_cluster_custom_object worked for namespace scoped custom objects.

@roycaihw
Copy link
Member

@jparklab ah you're right, I misread the original issue. Although list_custom_object_for_all_namespaces and list_cluster_custom_object happens to talk to the same API endpoint, it may be better to have a list_custom_object_for_all_namespaces method for documentation purpose. kubernetes-client/java#941 (comment) is the right way to fix this issue. Since this issue affects multiple clients, would you mind filing an issue in https://github.com/kubernetes-client/gen about fixing the openapi spec?

@davidxia
Copy link

@roycaihw I created issue kubernetes-client/gen#268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants