Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add WriteVolumeCache API" #93

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,313 changes: 0 additions & 1,313 deletions client/api/volume/v1beta2/api.pb.go

This file was deleted.

132 changes: 0 additions & 132 deletions client/api/volume/v1beta2/api.proto

This file was deleted.

92 changes: 0 additions & 92 deletions client/groups/volume/v1beta2/client_generated.go

This file was deleted.

1 change: 0 additions & 1 deletion integrationtests/volume_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@ func simpleE2e(t *testing.T) {
if err != nil {
t.Fatalf("Volume id %s mount to path %s failed. Error: %v", volumeID, mountPath, err)
}

// Dismount the volume
dismountVolumeRequest := &v1alpha1.DismountVolumeRequest{
VolumeId: volumeID,
Expand Down
10 changes: 0 additions & 10 deletions internal/os/volume/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,6 @@ func (VolAPIImplementor) FormatVolume(volumeID string) (err error) {
return nil
}

// WriteVolumeCache - Writes the file system cache to disk with the given volume id
func (VolAPIImplementor) WriteVolumeCache(volumeID string) (err error) {
cmd := fmt.Sprintf("Get-Volume -UniqueId \"%s\" | Write-Volumecache", volumeID)
out, err := runExec(cmd)
if err != nil {
return fmt.Errorf("error writing volume cache. cmd: %s, output: %s, error: %v", cmd, string(out), err)
}
return nil
}

// IsVolumeFormatted - Check if the volume is formatted with the pre specified filesystem(typically ntfs).
func (VolAPIImplementor) IsVolumeFormatted(volumeID string) (bool, error) {
cmd := fmt.Sprintf("(Get-Volume -UniqueId \"%s\" -ErrorAction Stop).FileSystemType", volumeID)
Expand Down
7 changes: 0 additions & 7 deletions internal/server/volume/api_group_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions internal/server/volume/internal/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,6 @@ type FormatVolumeRequest struct {
type FormatVolumeResponse struct {
}

type WriteVolumeCacheRequest struct {
VolumeId string
}

type WriteVolumeCacheResponse struct {
}

type DismountVolumeRequest struct {
VolumeId string
Path string
Expand Down
1 change: 0 additions & 1 deletion internal/server/volume/internal/types_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions internal/server/volume/internal/v1beta2/conversion.go

This file was deleted.

Loading