Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot secret reference to group snapshot controller. #1034

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add snapshot secret reference to group snapshot controller. #1034

merged 1 commit into from
Mar 25, 2024

Conversation

manishym
Copy link
Contributor

@manishym manishym commented Mar 13, 2024 •
edited
Loading

Fixes: #834

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Adds secret reference to group snapshots

Which issue(s) this PR fixes:
Automatically closes linked issue when PR is merged.
Usage: Fixes #<issue number>, or Fixes (paste link of issue).
If PR is about failing-tests or flakes, please post the related issues/tests in a comment and do not use Fixes
-->
Fixes #834

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Adds secret reference to volume group snapshot content.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Mar 13, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 13, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: manishym / name: Manish M Yathnalli (e171a98)

@manishym manishym marked this pull request as draft March 13, 2024 08:36
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @manishym!

It looks like this is your first PR to kubernetes-csi/external-snapshotter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-snapshotter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @manishym. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 13, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2024
@manishym manishym marked this pull request as ready for review March 18, 2024 08:34
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2024
Madhu-1
Madhu-1 reviewed Mar 19, 2024
View reviewed changes
pkg/common-controller/groupsnapshot_controller_helper.go Outdated Show resolved Hide resolved
pkg/sidecar-controller/groupsnapshot_helper.go Outdated Show resolved Hide resolved
pkg/sidecar-controller/groupsnapshot_helper.go Outdated Show resolved Hide resolved
pkg/sidecar-controller/snapshot_controller.go Outdated Show resolved Hide resolved
pkg/sidecar-controller/snapshot_controller.go Outdated Show resolved Hide resolved
pkg/sidecar-controller/snapshot_controller.go Outdated Show resolved Hide resolved
pkg/utils/util.go Outdated Show resolved Hide resolved
pkg/utils/util.go Outdated Show resolved Hide resolved
pkg/utils/util.go Outdated Show resolved Hide resolved
pkg/utils/util.go Outdated Show resolved Hide resolved
@Madhu-1
Copy link
Contributor

Madhu-1 commented Mar 19, 2024

/assign @xing-yang
/assign @nixpanic

@nixpanic
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2024
Madhu-1
Madhu-1 reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits, overall LGTM

pkg/common-controller/groupsnapshot_controller_helper.go Outdated Show resolved Hide resolved
pkg/utils/util.go Outdated Show resolved Hide resolved
pkg/utils/util.go Outdated Show resolved Hide resolved
pkg/sidecar-controller/snapshot_controller.go Outdated Show resolved Hide resolved
@manishym manishym force-pushed the secretReference branch 2 times, most recently from 5e1f0b0 to dd2531a Compare March 21, 2024 17:12
@manishym manishym requested a review from Madhu-1 March 21, 2024 17:13
Madhu-1
Madhu-1 reviewed Mar 22, 2024
View reviewed changes
pkg/utils/util.go Outdated Show resolved Hide resolved
Madhu-1
Madhu-1 reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, LGTM

pkg/utils/util.go Outdated Show resolved Hide resolved
@nixpanic
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2024
@nixpanic nixpanic removed their assignment Mar 22, 2024
@Madhu-1
Copy link
Contributor

Madhu-1 commented Mar 22, 2024

@xing-yang @RaunakShah can you please review this PR?

@xing-yang
Copy link
Collaborator

Please add a release note.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 25, 2024
@xing-yang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manishym, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 67dcee2 into kubernetes-csi:master Mar 25, 2024
8 checks passed
@Madhu-1 Madhu-1 mentioned this pull request Mar 26, 2024
Closed
@mpatlasov mpatlasov mentioned this pull request Mar 29, 2024
Merged
@manishym manishym mentioned this pull request Aug 27, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 left review comments

@xing-yang xing-yang xing-yang left review comments

@nixpanic nixpanic nixpanic left review comments

@humblec humblec Awaiting requested review from humblec

@mauriciopoppe mauriciopoppe Awaiting requested review from mauriciopoppe

@pohly pohly Awaiting requested review from pohly

@RaunakShah RaunakShah Awaiting requested review from RaunakShah

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add secrets in CreateVolumeGroupSnapshots
5 participants
@manishym @k8s-ci-robot @Madhu-1 @nixpanic @xing-yang