Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CreationTime in VolumeGroupSnapshotContentStatus from *int64 to *metav1.Time #1235

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

leonardoce
Copy link
Contributor

@leonardoce leonardoce commented Dec 9, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1234

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`VolumeGroupSnapshotContent.status.creationTime` is now a metav1.Time instead of an unix epoch time

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 9, 2024
@leonardoce
Copy link
Contributor Author

This is an example:

apiVersion: groupsnapshot.storage.k8s.io/v1beta1
kind: VolumeGroupSnapshot
metadata:
  annotations: [...]
  creationTimestamp: "2024-12-09T11:25:06Z"
  finalizers:
  - groupsnapshot.storage.kubernetes.io/volumegroupsnapshot-bound-protection
  generation: 1
  name: new-groupsnapshot-demo
  namespace: default
  resourceVersion: "5978312"
  uid: 6a6fd6de-5f59-4905-b597-fa6eb804365c
spec:
  source:
    selector:
      matchLabels:
        cnpg.io/instanceName: cluster-example-1
  volumeGroupSnapshotClassName: csi-hostpath-groupsnapclass
status:
  boundVolumeGroupSnapshotContentName: groupsnapcontent-6a6fd6de-5f59-4905-b597-fa6eb804365c
  creationTime: "2024-12-09T11:25:06Z"
  readyToUse: true
---
apiVersion: groupsnapshot.storage.k8s.io/v1beta1
kind: VolumeGroupSnapshotContent
metadata:
  creationTimestamp: "2024-12-09T11:25:06Z"
  finalizers:
  - groupsnapshot.storage.kubernetes.io/volumegroupsnapshotcontent-bound-protection
  generation: 1
  name: groupsnapcontent-6a6fd6de-5f59-4905-b597-fa6eb804365c
  resourceVersion: "5978282"
  uid: a2588324-6c6d-4ca3-9ea3-ad6b02ba81eb
spec:
  deletionPolicy: Delete
  driver: hostpath.csi.k8s.io
  source:
    volumeHandles:
    - 144f5adc-a591-11ef-a409-4ebdfafda5f0
    - 145063c3-a591-11ef-a409-4ebdfafda5f0
  volumeGroupSnapshotClassName: csi-hostpath-groupsnapclass
  volumeGroupSnapshotRef:
    apiVersion: groupsnapshot.storage.k8s.io/v1beta1
    kind: VolumeGroupSnapshot
    name: new-groupsnapshot-demo
    namespace: default
    resourceVersion: "5978268"
    uid: 6a6fd6de-5f59-4905-b597-fa6eb804365c
status:
  creationTime: "2024-12-09T11:25:06Z"
  readyToUse: true
  volumeGroupSnapshotHandle: 3e17685f-b620-11ef-b805-0eeddb14961f
  volumeSnapshotHandlePairList:
  - snapshotHandle: 3e176af8-b620-11ef-b805-0eeddb14961f
    volumeHandle: 144f5adc-a591-11ef-a409-4ebdfafda5f0
  - snapshotHandle: 3e7b6312-b620-11ef-b805-0eeddb14961f
    volumeHandle: 145063c3-a591-11ef-a409-4ebdfafda5f0

/assign @xing-yang

@xing-yang
Copy link
Collaborator

Can you change "proper time" to "metav1.Time" in the release note?

The code looks good to me.

@xing-yang
Copy link
Collaborator

/assign @msau42 @gnufied

@gnufied
Copy link
Contributor

gnufied commented Dec 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@msau42
Copy link
Collaborator

msau42 commented Dec 9, 2024

/lgtm

@xing-yang
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leonardoce, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit c0cb7b7 into kubernetes-csi:master Dec 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change CreationTime in VolumeGroupSnapshotContentStatus from *int64 to *metav1.Time
5 participants