-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CreationTime in VolumeGroupSnapshotContentStatus from *int64 to *metav1.Time #1235
Conversation
This is an example:
/assign @xing-yang |
Can you change "proper time" to "metav1.Time" in the release note? The code looks good to me. |
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leonardoce, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1234
Special notes for your reviewer:
Does this PR introduce a user-facing change?: