Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Volunteer to help review #656

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Conversation

hex108
Copy link
Contributor

@hex108 hex108 commented Mar 21, 2019

What this PR does / why we need it:
I have been a little familiar with the code base. I'd like to help review issues/PRs if it is OK. :)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 21, 2019
@k82cn
Copy link
Contributor

k82cn commented Mar 21, 2019

/lgtm
/approve

Thanks very much for your contribution :)

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hex108, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0c61406 into kubernetes-retired:master Mar 21, 2019
@hex108
Copy link
Contributor Author

hex108 commented Mar 21, 2019

Thanks @k82cn !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants