Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Fix Resource Sub exception in Reclaim&Preempt Actions #660

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix Resource Sub exception in Reclaim&Preempt Actions #660

merged 1 commit into from
Mar 27, 2019

Conversation

TommyLike
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #659

Special notes for your reviewer:
Considering the case below:

Resource 1 <cpu 1000.00, memory 100.00, GPU 0.00> 
Resource 2 <cpu 100.00, memory 1000.00, GPU 0.00>

The LessEqual method will always fail no matter which is used as left operand

Release note:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2019
@k82cn
Copy link
Contributor

k82cn commented Mar 25, 2019

please merge the commit into one.

@k82cn
Copy link
Contributor

k82cn commented Mar 25, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2019
@k82cn
Copy link
Contributor

k82cn commented Mar 25, 2019

/cc @Donghuizhuo

@k8s-ci-robot
Copy link
Contributor

@k82cn: GitHub didn't allow me to request PR reviews from the following users: Donghuizhuo.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Donghuizhuo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hex108
Copy link
Contributor

hex108 commented Mar 26, 2019 •
edited
Loading

The patch LGTM.

It is better to some explanation for the preconditions of the function Sub. And we should check other places calling Sub, we could do it in another PR.

@zionwu zionwu mentioned this pull request Mar 26, 2019
Closed
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 27, 2019
@k82cn k82cn self-assigned this Mar 27, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 27, 2019
@k82cn
Copy link
Contributor

k82cn commented Mar 27, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 40070d3 into kubernetes-retired:master Mar 27, 2019
This was referenced Mar 28, 2019
Closed
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 29, 2019
@k8s-ci-robot
Merge pull request #685 from asifdxtreme/automated-cherry-pick-of-#643-…
bffcc78 
…#642-#638-#645-#647-#651-#652-#655-#658-#649-#660-#666-#671-#673-upstream-release-0.4

Automated cherry pick of #643: Return err in Allocate if any error occurs #642: Add event when task is scheduled #638: Take init containers into account when getting pod resource #645: Order task by CreationTimestamp first, then by UID #647: In allocate, skip adding Job if its queue is not found #651: Return err in functions of session.go if any error occurs #652: Change run option SchedulePeriod's type to make it clear #655: Do graceful eviction using default policy #658: Address helm install error in tutorial.md #649: Preempt lowest priority task first #660: Fix sub exception in reclaim and preempt #666: Fix wrong caculation for deserved in proportion plugin #671: Change base image to alphine to reduce image size #673: Do not create PodGroup and Job for task whose scheduler is
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
@k8s-ci-robot
Merge pull request kubernetes-retired#660 from TommyLike/bug/fix_sub_…
84380c1 
…error

Fix Resource Sub exception in Reclaim&Preempt Actions
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
@k8s-ci-robot
Merge pull request kubernetes-retired#660 from TommyLike/bug/fix_sub_…
d78f760 
…error

Fix Resource Sub exception in Reclaim&Preempt Actions
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
@k8s-ci-robot
Merge pull request kubernetes-retired#660 from TommyLike/bug/fix_sub_…
ad0cdf2 
…error

Fix Resource Sub exception in Reclaim&Preempt Actions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@k82cn k82cn k82cn left review comments

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kube batch exit with Resource is not sufficient panic randomly.
4 participants
@TommyLike @k82cn @k8s-ci-robot @hex108