This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
chore: disable CrossClusterDiscovery feature by default #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
hectorj2f
force-pushed
the
hectorj2f/disable_crossclusterdiscovery
branch
from
f5f63fd to
9d368f9
Compare
|
The in-memory controller errors are failing. I'll check how to enable the feature only for those tests. |
hectorj2f
force-pushed
the
hectorj2f/disable_crossclusterdiscovery
branch
from
9d368f9 to
1997a29
Compare
k8s-ci-robot
added
size/M
hectorj2f
force-pushed
the
hectorj2f/disable_crossclusterdiscovery
branch
2 times, most recently
from
fe26914 to
f3b1c2d
Compare
hectorj2f
force-pushed
the
hectorj2f/disable_crossclusterdiscovery
branch
from
f3b1c2d to
4d3be0e
Compare
k8s-ci-robot
added
size/S
|
Thanks @hectorj2f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
By the reactions in GH #1283, this feature does not seem to be used. It is an alpha feature that is handling certain features that should not be tackled by kubefed, but instead use other tools such as Istio.
I am disabling it by default for now. Note that, this feature is in an alpha stage so it could be deleted in the future reduce the maintenance burden.
related to #1283
Special notes for your reviewer: