-
Notifications
You must be signed in to change notification settings - Fork 533
optimize chart readme #1328
optimize chart readme #1328
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
e1c7144
to
36b3fd5
Compare
/lgtm Thanks a lot, @huiwq1990. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @huiwq1990
I might be missing something, but it appears like there are duplicates. Please check and let me know.
charts/kubefed/README.md
Outdated
| controllermanager.webhook.repository | Repo of the KubeFed image. | quay.io/kubernetes-multicluster | | ||
| controllermanager.webhook.image | Name of the KubeFed image. | kubefed | | ||
| controllermanager.webhook.tag | Tag of the KubeFed image. | canary | | ||
| controllermanager.controller.replicaCount | Number of replicas for KubeFed controller manager. | 1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a repeat of line 107?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i have fix them.
charts/kubefed/README.md
Outdated
| controllermanager.webhook.image | Name of the KubeFed image. | kubefed | | ||
| controllermanager.webhook.tag | Tag of the KubeFed image. | canary | | ||
| controllermanager.controller.replicaCount | Number of replicas for KubeFed controller manager. | 1 | | ||
| controllermanager.controller.imagePullPolicy | Image pull policy. | IfNotPresent | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean controllermanager.webhook.imagePullPolicy
?
@irfanurrehman I have recheck my pr, and fix them. |
We should put all options in (alphabetic?) order but that can be done in a subsequent PR. /lgtm |
I prefer organize them by kubefed’s module(webhook,controller). User know how to config them at first glance. |
Thanks @huiwq1990 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huiwq1990, irfanurrehman, makkes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: