Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change security-group-inbound-cidr to just inbound-cidr #733

Merged
merged 1 commit into from
Nov 14, 2018
Merged

change security-group-inbound-cidr to just inbound-cidr #733

merged 1 commit into from
Nov 14, 2018

Conversation

M00nF1sh
Copy link
Collaborator

Changes:

  • change security-group-inbound-cidrs annotation to inbound-cidrs

Test done:

  • use security-group-inbound-cidrs, the cidrs will take effect, with deprecation warning.
  • use inbound-cidrs, the cidrs will take effect

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2018
@bigkraig
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 418fc42 into kubernetes-sigs:master Nov 14, 2018
@M00nF1sh M00nF1sh deleted the inbound branch December 7, 2018 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants